Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method for retrieving 'oauth_consumer_key' and 'oauth_consumer… #1743

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Conversation

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still prefer to get them via foreman-rake config | grep oauth or foreman-rake -- config -k oauth_consumer_key. Those are official interfaces that I would support. They use the application logic. When you don't use the installer, you can leave them out of settings.yaml and only set them in the database. Following the application logic prepares us better for a future where we might want to support containers.

…e79d2bb  …_secret' (Revised)

As requested, updated to use foreman-rake.
Note: used 'sudo', as I was not able to determine the password an unprivelged user should use when executing the command without sudo(8)
@illumino illumino requested a review from ekohl December 10, 2020 23:31
@illumino
Copy link
Contributor Author

@ekohl did the update not meet your requirements?
Or did the changes just get missed?

@ekohl
Copy link
Member

ekohl commented Oct 20, 2021

Or did the changes just get missed?

This. My apologies for keeping this open so long.

@ekohl ekohl merged commit 43d7d52 into theforeman:gh-pages Oct 20, 2021
@illumino illumino deleted the patch-1 branch October 23, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants